Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheels.yml workflow for release to PyPI #106

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

milesgranger
Copy link
Collaborator

No description provided.

@milesgranger milesgranger force-pushed the milesgranger/add-release-workflow branch from ee03ffa to cf327ac Compare November 6, 2023 14:10
Comment on lines +4 to +5
push:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually have to run on push/pull_request? I would expect release to be sufficient. push maybe but only for main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, I did that because the actual uploading does a check for tags being present.

if: "startsWith(github.ref, 'refs/tags/')"

Thought maybe it'd be useful to ensure the project builds successfully, but maybe it's overkill.

@fjetter fjetter merged commit d569f71 into dask:main Nov 6, 2023
7 checks passed
@milesgranger milesgranger deleted the milesgranger/add-release-workflow branch November 6, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants